Fix condition for keepalive. Fixes issue #23

r3b / grunt-protractor-coverage

Coverage analysis for Protractor tests

Apache License 2.0

38 stars 29 forks source link

Fix condition for keepalive. Fixes issue #23 #24

Closed elzes closed 10 years ago

elzes commented 10 years ago

The keepalive check didn't work anymore

elzes commented 10 years ago

@mdasberg Is this a correct fix for your code change?

r3b commented 10 years ago

I think @mdasberg's condition should still pass after you've added the grouping. Operator precedence would've caused the previous revision to be interpreted as (code === 1 || (code === 100 && keepAlive)), which would work for the shard failure but disregard the keepalive for spec failure. I need to get more familiar with the shard functionality to write some test cases.