r3b / grunt-protractor-coverage

Coverage analysis for Protractor tests
Apache License 2.0
38 stars 29 forks source link

Remove unndecessary grunt.expand where it might even hang the process #68

Closed ali-bugdayci closed 7 years ago

ali-bugdayci commented 7 years ago

https://github.com/r3b/grunt-protractor-coverage/blob/master/tasks/protractor_coverage.js#L98

    var saveCoverageTemplate = grunt.file.expand([ opts.saveCoverageTemplate, "node_modules/grunt-protractor-coverage/resources/saveCoverage.tmpl", path.join(__dirname, '..') + '/**/resources/saveCoverage.tmpl']).shift();
    if(!saveCoverageTemplate){
      grunt.fail.fatal("Coverage template file not found.");
    }
grunt.file.expand([ opts.saveCoverageTemplate, "node_modules/grunt-protractor-coverage/resources/saveCoverage.tmpl", process.cwd()+'/**/resources/saveCoverage.tmpl']).shift();

hence the following is unnecessary

process.cwd()+'/**/resources/saveCoverage.tmpl' 
process.cwd()+'/**/resources/saveCoverage.tmpl'