search

r3bl-org / shortlink

This Chrome extension provides a browser action that simply allows the user to create a shortlink for all the selected tabs in the current window. It can be activated via a keyboard shortcut Alt + L. To use it, in the omnibar, type go then press Tab, then type the phrase you have created a shortlink for earlier & it will open the tab(s).
https://chrome.google.com/webstore/detail/shorty/ffhfkgcfbjoadmhdmdcmigopbfkddial?hl=en-US&gl=US
MIT License
11 stars 13 forks source link

Implemented shortlink input with '_' separator and multiple copy using "," #12

Closed amitx13 closed 1 year ago

amitx13 commented 1 year ago

new shortlinks are added with removed spaces or commas and replace them with _ Eg: foo, bar ,is saved as foo_bar (commas and spaces are replaced w/ underscores, then remove multiple underscores).

Extend the copy/c command such that you can pass in multiple arguments that are comma delimited. These should all be copied to the clipboard & joined w/ \n. Eg: copy foo_bar,baz

nazmulidris commented 1 year ago

@amitx13 Thank you for spending your time on this PR. Unfortunately I can't accept it as is. Here are a few things to note, it is desirable to: 1) run the code through prettier to format it consistently w/ the rest of the code base 2) have functions that encapsulate the logic cleanly 3) have tests for the functions added above 4) refactor all the code after writing it for the best readability.

nazmulidris commented 1 year ago

@amitx13 Thank you for spending time on this. Even though we didn't accept your PR, we added hacktoberfest-accepted label to it, so you should get credit for it.

amitx13 commented 1 year ago

@nazmulidris thank you sir for your feedback and support I will not make these mistake again

nazmulidris commented 1 year ago

@amitx13 No need to apologize. Thank you so much for taking the time to contribute. This is a long journey and there are lots of things to learn.