r3bl-org / shortlink

This Chrome extension provides a browser action that simply allows the user to create a shortlink for all the selected tabs in the current window. It can be activated via a keyboard shortcut Alt + L. To use it, in the omnibar, type go then press Tab, then type the phrase you have created a shortlink for earlier & it will open the tab(s).
https://chrome.google.com/webstore/detail/shorty/ffhfkgcfbjoadmhdmdcmigopbfkddial?hl=en-US&gl=US
MIT License
11 stars 13 forks source link

Allow mouse click in popup to open tabs #3

Closed nazmulidris closed 1 year ago

nazmulidris commented 1 year ago

In the popup, currently all the shortlink names are displayed. But they aren't clickable. Make them clickable, so that a user can open tabs with their mouse & not have to type anything.

Optional - Further refinement would be to allow Tab focus traversal and Enter to open the tabs themselves.

JoHeyJo commented 1 year ago

I'm going to take a crack at this!

nazmulidris commented 1 year ago

@JoHeyJo Awesome! This is assigned to you! 👍🏽

JoHeyJo commented 1 year ago

@nazmulidris I'll PR on Sunday so it counts towards Hacktoberfest, as long as you don't mind. Also, how do you feel if I make the "Optional feature" a separate issue? I also wouldn't mind taking a crack at that.

nazmulidris commented 1 year ago

@JoHeyJo PR on Sunday sounds great! I will be sure to mark the PR with hacktoberfest-accepted label 👍🏽 .

And making the optional feature a separate issue sounds great as well! 🙏🏽

nazmulidris commented 1 year ago

@JoHeyJo I just went through a major refactor of the code base ("promise-ifying" the chrome.storage API so it is easy to use), so hopefully this will make it easier to work with.

nazmulidris commented 1 year ago

@JoHeyJo Also if you like to chat about this issue or PR this is the discord server for the project: https://discord.gg/UejyhKfx