search

r3c / custom_from

Plugin for Roundcube webmail, enable virtual email sender input.
https://plugins.roundcube.net/#/packages/r3c/custom-from
Other
20 stars 16 forks source link

Current Master breaks with Roundcube 1.0 #8

Closed kermit-the-frog closed 10 years ago

kermit-the-frog commented 10 years ago

Hi,

I tried to install the current master on my Roundcube 1.0 installation. But when i activate the plugin roundcube does not show any messages in the inbox. There is no error in the error.log. The 1.3 relase works perfectly but I'd like to use #6 ("Support for pulling email address from arbitrary header")

Can anyone help me? Regards kermit-the-frog

r3c commented 10 years ago

Hi,

did you read issue #7? Custom-From works fine with Roundcube 1.0, please double-check your install (folder, permissions, etc).

Regards.

kermit-the-frog commented 10 years ago

Hi, I did read #7. But that didn't help me at all. Let me tell you what I have tried so far:

1.) Download from https://github.com/r3c/CustomFrom/archive/master.zip 2.) Extract the archive to a local directory 3.) Upload of CustromFrom-master\custrom_from to the plugin directory of my roundcube installation via ftp 4.) Activate custom_from in the config

If I login roundcube says there are no messages in the inbox. If I disable the plugin everything is ok.

Regards, Martin

r3c commented 10 years ago

And did you check plugin folder permissions? Again, I tested the plugin with a fresh new install of Roundcube 1.0 and everything works fine, there was no incompatible change introduced since last release of Roundcube.

kermit-the-frog commented 10 years ago

I checked every line of 8410704. And I found the problem. See my comments on that commit.

r3c commented 10 years ago

Default configuration of custom_from doesn't include any space in "custom_from_header_rules" option value, so the "trim" is not required unless you used a different value with a space in it.

Also, see the "parse_headers" function in custom_from.php already trims both keys and values when reading this configuration value, so there should no be point adding the other "trim" call you suggest, unless "fetch_headers" has already been corrupted with whitespaces.

Are you using another plugin that also affects the "fetch_headers" value?

kermit-the-frog commented 10 years ago

Custom_from is the only plugin I'm running. And $params['fetch_headers'] = $params['fetch_headers'] . ' ' . $header; definitely leaves a blank at the beginning of $params['fetch_headers'] if $params['fetch_headers'] has been empty before.

r3c commented 10 years ago

Did you try this fix on your install? I can't reproduce your issue, and it seems other users were able to run the plugin without modification.

What IMAP server are you using?

r3c commented 10 years ago

The issue you noticed may have been corrected by pull request #9

kermit-the-frog commented 10 years ago

Solved by #9