search

r3c / yaronet

Lightweight, traditionnal but full-featured PHP bulletin board
https://www.yaronet.com
GNU Affero General Public License v3.0
17 stars 4 forks source link

Handle youtube url with a "s" at the end of the start time parameter. #13

Closed UtherII closed 2 years ago

UtherII commented 2 years ago

Fix for bug reported at https://www.yaronet.com/topics/193011-video-youtube-avec-depart-decale#post-4

r3c commented 2 years ago

Thanks again, feel free to merge whenever you please 🙂

UtherII commented 2 years ago

I'm not used to Github. I'm not sure how to merge. Are you sure I have the rights to do that myself? I can't see a merge button.

r3c commented 2 years ago

Oh sorry I think you do have the permission, unless I missed something in the configuration. You should have a "Rebase and merge" button appearing at the bottom of https://github.com/r3c/yaronet/pull/13 ; if you don't let me know, I'll merge the PR for you and will try to figure out what's wrong 🙂

UtherII commented 2 years ago

I guess there is actually an issue with permissions since at the bottom of the pull request page, I have :

This branch has no conflicts with the base branch Only those with write access to this repository can merge pull requests.

There are only a "Close pull request" button and a "Comment" button

r3c commented 2 years ago

OK then I just merged it, thanks again!