r3fang / SnapATAC

Analysis Pipeline for Single Cell ATAC-seq
GNU General Public License v3.0
300 stars 125 forks source link

PBMC 10K & 5K findDAR issue #118

Open ScienceBear opened 4 years ago

ScienceBear commented 4 years ago

Hi Rongxin,

I'm running into an issue with the PBMC vignette. At:

DARs = findDAR( obj=x.sp, input.mat="pmat", cluster.pos="CD14+ Monocytes", cluster.neg.method="knn", test.method="exactTest", bcv=0.4, #0.4 for human, 0.1 for mouse seed.use=10 );

I get a "cluster.pos does not exist in cluster" error.

I looked into x.sp's structure and it seems that cluster.pos are still numeric. I can get round this issue by defining cluster.pos="1", but it seems there's a step missing where clusters are relabelled in x.sp. Sorry if I've missed something obvious, but could you advise?

Thanks again for your work on this pipeline. (: