r3fang / SnapATAC

Analysis Pipeline for Single Cell ATAC-seq
GNU General Public License v3.0
301 stars 125 forks source link

Wrong parameters for MACS2 #152

Open suragnair opened 4 years ago

suragnair commented 4 years ago

https://github.com/r3fang/SnapATAC/blob/c3ab177558f0fe9c47cbd68969df7b06de5b07d9/R/runMACS.R#L32

According to the MACS2 page the settings --shift -100 --extsize 200 should be used for DNase-seq/ATAC-seq data.

--nomodel --shift 37 --extsize 73 should be used for nuclesome-seq data.

hjack123 commented 4 years ago

The webpage doesn't say ATAC-seq data though. I don't think DNase-seq is equivalent to ATAC-seq?

nes-b commented 4 years ago

Have a look at this issue: https://github.com/taoliu/MACS/issues/331

Followig this argumentation, it should be reasonable to use DNase-seq equivalent params. Instead, scaling to --shift -75 --extsize 150 might be biologically appropriate, too.

suragnair commented 4 years ago

The above is correct. ENCODE also uses --shift -75 --extsize 150.