r3fang / SnapATAC

Analysis Pipeline for Single Cell ATAC-seq
GNU General Public License v3.0
301 stars 125 forks source link

potential bug with adding pmat via snaptools snap.py getFragFromBarcode #200

Open danielgchen opened 4 years ago

danielgchen commented 4 years ago

Hi, I noticed when I was adding the PMAT via fixed narrowpeak files (turned b'chr1' turn chr1) there were a bit of issues so I looked at the function and noticed that you initially add the decoded (e.g. chr1) for chromosomes but then rewrite it with then undecided (e.g. b'chr1') version of the chromosomes/contigs, as shown below image Is there any reason why, if not would it be possible to change it to _chroms = [item.decode() for item in f["FM"]["fragChrom"][barcode_pos_list]]; in the next update to make it clearer? Thanks!