r3fang / SnapATAC

Analysis Pipeline for Single Cell ATAC-seq
GNU General Public License v3.0
296 stars 125 forks source link

runEigDecomp function results in NaN #237

Open marvinquiet opened 2 years ago

marvinquiet commented 2 years ago

Thank you for your great work in developing such a wonderful pipeline for analyzing scATAC-seq.

When using it from my own experience, I noticed that in the runEigDecomp function under https://rdrr.io/github/r3fang/SnapATAC/src/R/utilities.R. The transitions <- as.matrix(d_rot1 %*% norm_p1 %*% d_rot1); may generate NaNs which hinders the calculation on obj@smat@sdev. This can result in an incorrect diffusion map.

I wonder if I can simply replace those NaNs as 0s? Thank you in advance!