Minor/Warning issue: 'rBind' is deprecated

[hypercompetent]

Hi Rongxin,

Thanks for this fantastic package - I'm using it now along with your very nice documentation to analyze multiple 10x runs together.

I noticed this Warning message pop up when I ran:

> snap <- Reduce(snapRbind, snap.list)
Warning message:
'rBind' is deprecated.
 Since R version 3.2.0, base's rbind() should work fine with S4 objects

This is clearly not a show-stopper, but I thought I'd add it here in case you'd like to swap in rbind for rBind and have one less warning. Since SnapATAC requires R > 3.4.0, rbind should work.

Cheers, -Lucas

[r3fang]

Hi Lucas,

I am sorry for the late response and thank you for the suggestion, I have recently moved from San Diego to Boston and was quite busy for the last few weeks. I will update it this week

On Sep 16, 2019, at 3:05 PM, Lucas Graybuck notifications@github.com wrote:

Hi Rongxin,

Thanks for this fantastic package - I'm using it now along with your very nice documentation to analyze multiple 10x runs together.

I noticed this Warning message pop up when I ran:

snap <- Reduce(snapRbind, snap.list) Warning message: 'rBind' is deprecated. Since R version 3.2.0, base's rbind() should work fine with S4 objects This is clearly not a show-stopper, but I thought I'd add it here in case you'd like to swap in rbind for rBind and have one less warning. Since SnapATAC requires R > 3.4.0, rbind should work.

Cheers, -Lucas

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/r3fang/SnapATAC/issues/98?email_source=notifications&email_token=ABT6GG4LVVNRPD7EMWTDP5DQJ7KF3A5CNFSM4IXGCXBKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HLVICEQ, or mute the thread https://github.com/notifications/unsubscribe-auth/ABT6GG4T6MZG5ZTCNN5ZSGDQJ7KF3ANCNFSM4IXGCXBA.

[hypercompetent]

No problem! This is very minor.

I hope the move has gone well! Cheers, -Lucas