r3labs / sse

Server Sent Events server and client for Golang
Mozilla Public License 2.0
857 stars 179 forks source link

refactor: better error check(that handle wrap), use std constants, typos and fields alignement #156

Closed GreyXor closed 6 months ago

GreyXor commented 1 year ago
fieldalignment -fix .
/home/greyxor/Documents/Projects/sse/client.go:42:13: struct with 128 pointer bytes could be 120
/home/greyxor/Documents/Projects/sse/server.go:17:13: struct with 56 pointer bytes could be 32
/home/greyxor/Documents/Projects/sse/stream.go:14:13: struct with 136 pointer bytes could be 96
/home/greyxor/Documents/Projects/sse/subscriber.go:10:17: struct with 40 pointer bytes could be 32
portante commented 1 year ago

Seems like a solid set of changes. Any reason for not merging this?

GreyXor commented 6 months ago

I switched to https://github.com/tmaxmax/go-sse