Fix(be): Protect against panic in EventLog.Replay - Githubissues

r3labs / sse

Server Sent Events server and client for Golang

Mozilla Public License 2.0

857 stars 179 forks source link

Fix(be): Protect against panic in EventLog.Replay #180

Closed robTheBuildr closed 5 months ago

robTheBuildr commented 5 months ago

How does this PR impact the user?

Users will not have machines crash on panic in EventLog.Replay.

Describe the Change

[ ] Add panic recovery to Stream.run
[ ] Add nil reference checks to EventLog.Replay

Describe the Root Cause (bug fixes only)

If the EventLog dies for any reason, or an event becomes nil, then the event should be skipped in Replay rather than causing a panic.

Limitations