r3nor / mullvad-tailscale

Use Mullvad VPN along with Tailscale and/or Zerotier
GNU General Public License v3.0
162 stars 7 forks source link

Wrong nft-related instructions in README #8

Closed edgar-vincent closed 2 years ago

edgar-vincent commented 2 years ago

The README says the user should "[set their] Tailscale/Zerotier network IPv6 IPs in the EXCLUDED_IPV6 variable (you can use CDIR notation), leave it blank if there are no IPv6s."

However, if the value is left blank, calling nft fails with:

Error: syntax error, unexpected newline
define EXCLUDED_IPV6 =
                      ^
mullvad-tailscale//mullvad.rules:16:16-28: Error: unknown identifier 'EXCLUDED_IPV6'; did you mean identifier ‘EXCLUDED_IPS’?
    ip6 daddr $EXCLUDED_IPV6 ct mark set 0x00000f41 meta mark set 0x6d6f6c65;

The user should be instructed to comment out these lines instead or, even better, the rules files should be generated from within mtc.