search

r4atlantis / atlantisom

Atlantis operating model. Generates data sets from Atlantis scenarios.
https://r4atlantis.github.io/atlantisom
8 stars 6 forks source link

kwsr or kswr #44

Closed vonStadarhraun closed 3 years ago

vonStadarhraun commented 3 years ago

Is this a typo? https://github.com/r4atlantis/atlantisom/blob/469277b8b49a10022573a5de83fff49f087d473f/R/load_biolprm.R#L115

"kswr" = kwsr

Cheers Jóhannes

ChristineStawitz-NOAA commented 3 years ago

Yes! I believe it should be kwsr everywhere..I'm not currently working but will fix this typo when I am back in the office. Thank you!

sgaichas commented 3 years ago

@ChristineStawitz-NOAA I just changed this in both load_biolprm.R and SS_write_biol.R, is it used anywhere else? 13af3c09fa5549226d3b1dc1a902cd8b980e588f and 4f47cb0fe82bd4c3e85b98221e50c4ed4ea38ab1

ChristineStawitz-NOAA commented 3 years ago

I think that is all, thank you Sarah!

On Fri, Jan 29, 2021 at 3:17 PM Sarah Gaichas notifications@github.com wrote:

@ChristineStawitz-NOAA https://github.com/ChristineStawitz-NOAA I just changed this in both load_biolprm.R and SS_write_biol.R, is it used anywhere else? 13af3c0 https://github.com/r4atlantis/atlantisom/commit/13af3c09fa5549226d3b1dc1a902cd8b980e588f and 4f47cb0 https://github.com/r4atlantis/atlantisom/commit/4f47cb0fe82bd4c3e85b98221e50c4ed4ea38ab1

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/r4atlantis/atlantisom/issues/44#issuecomment-770099905, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALNPO3JSDWJLPLAXZWNMCLTS4M6XVANCNFSM4WYW7A2Q .

-- Christine C. Stawitz, PhD. (pronouns: she/her)

Stock Assessment Model Developer,

Contractor with ECS Federal in support of NOAA Fisheries Office of Science and Technology | U.S. Department of Commerce

Mobile: 206-617-2060

www.fisheries.noaa.gov

Bai-Li-NOAA commented 3 years ago

There is a biolprm$kswr in calc_Z.R and the function works if I use biolprm$kwsr:

https://github.com/r4atlantis/atlantisom/blob/ef1eca4f79c15a3a759f94d58aeafe3e7320cac6/R/calc_Z.R#L71

sgaichas commented 3 years ago

Thank you @Bai-Li-NOAA this is now fixed with https://github.com/r4atlantis/atlantisom/commit/4511e31422d05ee4645f57f1b6bf3f09ccae997a

sgaichas commented 3 years ago

I searched all R files in atlantisom and found no other instances of the typo, so I hope that does it. :-)