r4dius / Iso2God

Decompiled Iso2God for quality of life improvements
36 stars 3 forks source link

[Request] Pull game info from XboxUnity & MobCat's database #9

Open Coolumin opened 1 week ago

Coolumin commented 1 week ago

A lot of executibles in Xbox 360 games have weird internal names instead of the proper ones used in the Marketplace, so it would be useful if there was a setting to pull them from online databases like XboxUnity instead.

iso2god-rs is an example of a tool that already uses XboxUnity for game names.

r4dius commented 1 week ago

I like this idea, I would prefer to have the list in a local file since it is now fixed. There's one available here https://github.com/IronRingX/xbox360-gamelist, I'll have a look :)

Coolumin commented 1 week ago

As an addendum, I have noticed ISO2GOD not being able to pull the XBE thumbnails from a few games like GTA San Andreas. In those situations, maybe they could be pulled from MobCat or something, since they appear to have a (almost?) complete archive of every game icon/thumbnail used for Xbox Classic games.

r4dius commented 1 week ago

I just tested this, in gta specifically there are 2 images in the xbe, one is the "thumbnail" and the other one is the "save file" icon or something like that, by default iso2god uses the "save file" icon if available, the 2 files are not in the same XPR image format for some reason, the "thumbnail" one is DXT1 and the "save game" icon is ARGB which is supposed to be supported by iso2god but there may be multiple formats for this I guess and iso2god only has one ARBG

I found this tool that support lots of them https://github.com/Ernegien/UIXTool/blob/main/src/Formats/Xpr/XprResource.cs but image format code it just over my mind, it'd be a pain for me to figure out what's needed as a simple fix rather than using multiple functions from this project,

So for now I changed the order so that the "thumbnail" icon is preferred by default but I can't guarantee some other games won't have the same format problem with "thumbnail" icon, I only used dead or alive ultimate and gta as isos to test so it'll need some testing from you 🤣

I tested the title renaming thing using a list file and I'm using the MobCat list for og xbox as it looked like the best one I could find, I need to compare multiple xbox 360 lists to find the best and clean a bit before release

Coolumin commented 1 week ago

I just tested this, in gta specifically there are 2 images in the xbe, one is the "thumbnail" and the other one is the "save file" icon or something like that, by default iso2god uses the "save file" icon if available, the 2 files are not in the same XPR image format for some reason, the "thumbnail" one is DXT1 and the "save game" icon is ARGB which is supposed to be supported by iso2god but there may be multiple formats for this I guess and iso2god only has one ARBG

I found this tool that support lots of them https://github.com/Ernegien/UIXTool/blob/main/src/Formats/Xpr/XprResource.cs but image format code it just over my mind, it'd be a pain for me to figure out what's needed as a simple fix rather than using multiple functions from this project,

So for now I changed the order so that the "thumbnail" icon is preferred by default but I can't guarantee some other games won't have the same format problem with "thumbnail" icon, I only used dead or alive ultimate and gta as isos to test so it'll need some testing from you 🤣

I tested the title renaming thing using a list file and I'm using the MobCat list for og xbox as it looked like the best one I could find, I need to compare multiple xbox 360 lists to find the best and clean a bit before release

Awesome! As for other games with a unsupported thumbnail, I saw that True Crime: New York City didn't work by default with the program.

r4dius commented 1 week ago

Yep icon is still fcked up in true crime, it'd need some code port to fix, btw are those icons visible anywhere in the console 😂 ? If not it may not "need" fix, the other blocking errors should be fixed

Coolumin commented 6 days ago

Yep icon is still fcked up in true crime, it'd need some code port to fix, btw are those icons visible anywhere in the console 😂 ? If not it may not "need" fix, the other blocking errors should be fixed

They're visible if you're using the game libraries in old official dashboards before Metro. I think the icons are shown in the Metro game library if the console is offline and/or the game isn't on MS's database. The storage settings in Microsoft's dashboard also shows icons for any STFS/SVOD content, like OG Xbox games converted or sold as GOD.

It's not a huge problem, since it's only aesthetic. The nitpicky part of my brain doesn't like it though.

r4dius commented 4 days ago

Yeah I don't like it either 😕, I borrowed the code from https://github.com/Ernegien/UIXTool/blob/main/src/Formats/Xpr/XprResource.cs and it looks ok for gta now (I can't find the true crime file I tested before), here's a build you can test please let me know if you see other games with a problem as this code only fixes 1 format and I have no idea if the other ones are used in xbox og xbe too iso2god-1.40-test-1.zip

Coolumin commented 3 days ago

Yeah I don't like it either 😕, I borrowed the code from https://github.com/Ernegien/UIXTool/blob/main/src/Formats/Xpr/XprResource.cs and it looks ok for gta now (I can't find the true crime file I tested before), here's a build you can test please let me know if you see other games with a problem as this code only fixes 1 format and I have no idea if the other ones are used in xbox og xbe too iso2god-1.40-test-1.zip

Yeah, this version of the program gets the icon for TC: NYC now. Really great to see the drag and dropping into the main window and "Redump" XGD1's working properly now too.

Coolumin commented 2 days ago

Well darn, it seems like 4947000B has an iffy icon too. image

r4dius commented 1 day ago

For some reason the game has thumbnail image + savegame icon and both are the same, iso2god expects savegame iso to be 64x64 and here it's 128x128, not sure why iso2god was not reading image size from headers has the code is there, I change it so it use it, I changed lots of other stuff so need to test it before release