Will create only one tag on the head, close #1

r4fun / keys

:keyboard: Keyboard Shortcuts for 'shiny'

https://r4fun.github.io/keys/

Other

45 stars 6 forks source link

Will create only one tag on the head, close #1 #2

Closed ColinFay closed 3 years ago

tylerlittlefield commented 3 years ago

Does this PR conflict with #3 ? It seems the lapply was removed in this PR but then added back in #3. Please let me know if I am mistaken as I think I could merged #3 to close #1.

ColinFay commented 3 years ago

Yes for #3 I got back from Master so that the two can be merged separately. And no, #3 won't completely close #1 (but #2 will).

It's possible that the two will conflict, but you should be able to solve that from the GitHub web interface :)

Let me know if you want me to rework this to make it easier to merge.

tylerlittlefield commented 3 years ago

Got it, thanks again!