r4g3baby / SimpleScore

A simple animated scoreboard plugin for your minecraft server.
https://www.spigotmc.org/resources/simplescore.23243/
MIT License
68 stars 34 forks source link

Scoreboard is getting cutoff when using ViaVersion for clients on <1.13 versions #19

Closed rickyy-yy closed 3 years ago

rickyy-yy commented 3 years ago

Hi, I'm running on Paper 1.17.1 and SimpleScore version 3.8.1. There are players experiencing this:

image

But, my scoreboard displays everything correctly, as such:

2021-08-02_08 59 30

I have PlaceholderAPI (v2.10.10) and ProtocolLib (v4.7.0) installed.

r4g3baby commented 3 years ago

Hey, are said players running on a lower/different minecraft version from the server? (This issue usually happens on servers running ViaVersion/ProtocolSupport).

rickyy-yy commented 3 years ago

Oh, that is probably the case, I didn't ask the player. Is there a way to fix this for lower/different versions?

r4g3baby commented 3 years ago

Setting ForceLegacy to true should fix the issue, however you will no longer be able to use hex colors and unlimited characters per line (you will be limited to 32 40 characters).

rickyy-yy commented 3 years ago

Oh that's quite a trade-off. Thanks for the quick support. :D

mbenitog commented 3 years ago

@r4g3baby Hi! I'm experiencing the same issue, but setting ForceLegacy to true does not fix it. Maybe this issue needs to be reopened, I can provide more detailed info if you need.

As you mentioned earlier, I'm using ViaVersion on a 1.17 Paper server and this issue appears on clients with <1.13 version. Protocolsupport has fixed this issue on their side, on the other hand ViaVersion has this pinned in their discord if it's of any help. Unfortunately ProtocolSupport doesn't fit my needs (PlaceHolder API) and I can´t use it.

r4g3baby commented 3 years ago

@r4g3baby Hi! I'm experiencing the same issue, but setting ForceLegacy to true does not fix it. Maybe this issue needs to be reopened, I can provide more detailed info if you need.

As you mentioned earlier, I'm using ViaVersion on a 1.17 Paper server and this issue appears on clients with <1.13 version. Protocolsupport has fixed this issue on their side, on the other hand ViaVersion has this pinned in their discord if it's of any help. Unfortunately ProtocolSupport doesn't fit my needs (PlaceHolder API) and I can´t use it.

Thanks for reaching out, I think I have solution for this so I'll reopen the issue until I can take a look into it.

r4g3baby commented 3 years ago

I have done a few changes that should improve compatibility with ViaVersion, if you have the time you can either compile the repo main branch or download this already compiled version of the plugin https://wormhole.app/qlzmJ#2wS60XbMp6Yw8jENitEX8Q

I haven't had the time to properly test it yet but once I do and if everything is working fine I'll release a new version on spigot.