search

r5n-dev / vscode-react-javascript-snippets

Extension for React/Javascript snippets with search supporting ES7+ and babel features
MIT License
1.72k stars 441 forks source link

React Snippets › Settings: Import React On Top not working #211

Closed AntonOfTheWoods closed 2 years ago

AntonOfTheWoods commented 2 years ago

I tried this both checked and unchecked, and both insert the import.

You made reference to a specific config option for this in https://github.com/dsznajder/vscode-react-javascript-snippets/issues/203. Was it this?

In that you make reference to snippets starting with "_" - have they been removed?

ice-chillios commented 2 years ago

@AntonOfTheWoods after changing this option, you should restart VSCode and just use rfc without _. I double checked and v4.0.4 works for me.

wKovacs64 commented 2 years ago

Doesn't seem to work for the ts variants?

ice-chillios commented 2 years ago

@wKovacs64 argh... another stuff that I forgot. I will open an issue to track it. Hope to find time on weekend to tackle the rest of formatting/perf issues.

wKovacs64 commented 2 years ago

@wKovacs64 argh... another stuff that I forgot. I will open an issue to track it. Hope to find time on weekend to tackle the rest of formatting/perf issues.

No worries, thanks for your efforts. I opened #214 to track it.

AntonOfTheWoods commented 2 years ago

@dsznajder was there something wrong with this ticket for tracking the issue? I understand not wanting to keep tickets open but I also noticed the problem using the extension with TS, and I could easily have made that more explicit in this ticket...