r5n-dev / vscode-react-javascript-snippets

Extension for React/Javascript snippets with search supporting ES7+ and babel features
MIT License
1.71k stars 440 forks source link

reactSnippets.settings.importReactOnTop not working #244

Open DavidArmendariz opened 2 years ago

DavidArmendariz commented 2 years ago

This configuration is not working. When I set this in my settings.json:

reactSnippets.settings.importReactOnTop

And then try to use any snippet, it is still importing React on the top.

chillios-dev commented 2 years ago

@DavidArmendariz please provide full settings.json related to reactSnippets and some repro as on my end works fine.

DavidArmendariz commented 2 years ago

@dsznajder I don't have any other configurations related to reactSnippets. I only have this in my settings.json:

"reactSnippets.settings.importReactOnTop": false,

The repro would be to type some command like rafce. It would give me something like this:

import React from 'react'

const index = () => {
  return (
    <div>index</div>
  )
}

export default index
chillios-dev commented 2 years ago

Did you reload vscode after changing this settings as extension said?

DavidArmendariz commented 2 years ago

@dsznajder Yes!

saulloalmeida commented 2 years ago

i'm having the same issue with reactSnippets.settings.importReactOnTop setting. Even setting it to false it still keeps showing up with the rfce snippet.

opes commented 2 years ago

I had this same issue recently start happening. I resolved it by toggling the setting on & off again, then invoking Developer: Reload Window.

notkiran commented 2 years ago

same issue, my setting snd settings.json has - "reactSnippets.settings.importReactOnTop": false, but still rafce is importing the react at top. please fix it. have restarted and reloaded the VS CODE

dougbeckwith commented 2 years ago

I'm also having the same issue with ImportReactOnTop setting not working

settings.json is set to this "reactSnippets.settings.importReactOnTop": false,

When i use the rafce snippet it generates

import React from 'react'

const App = () => {
  return (
    <div>App</div>
  )
}

export default App

please fix thanks :)

bradenmitchell commented 2 years ago

I am also experiencing this issue. I have done the following steps and it still places the import statement at the top:

  1. Set "reactSnippets.settings.importReactOnTop": true
  2. Reloaded window
  3. Ran rfc confirm import statement is present
  4. Set "reactSnippets.settings.importReactOnTop": false
  5. Reloaded window
  6. Ran rfc confirm import statement is still present (should not be present)
Jolsty commented 1 year ago

I am also having this issue. I am running the latest version (4.4.3) with the setting on false and it still imports React when i use the snippets

csfx-py commented 1 year ago

have the same issue, any updates on this?

push-on commented 1 year ago

disabling and enabling it fixed for me. but this solution is not permanent

Jolsty commented 1 year ago

I found that disabling this experimental setting made it work properly again!

image
hymced commented 9 months ago

As of today, this is still an issue, it feels like the reactSnippets.settings.importReactOnTop setting can disable it, but not re enable it after. I have tested everything:

The only thing that worked to add back the React import on top after disabling it, is the following: