r8-forks / webapp-improved

Automatically exported from code.google.com/p/webapp-improved
Other
0 stars 0 forks source link

pull-request: Include BaseSessionRequestHandler class in webapp2_extras.session #30

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
This is a slightly modified version of the example class in SessionStore.
The modification allows the example code to be configured with a 
'default_backend' setting in the config, so that normal users who most likely 
want sessions to be stored in the database backend on appengine can do so very 
easily.
changeset is here: 
http://code.google.com/r/joernhees-webapp2/source/detail?r=75e09133c0496132e98fe
83441e0defd27364022

Original issue reported on code.google.com by joernhees2 on 16 Nov 2011 at 6:43

GoogleCodeExporter commented 9 years ago
Thanks for this. It is a neat idea, however I don't want to add base handlers 
to webapp2. There are multiple ways that this could be done -- using mixins, 
using functions, etc, and I think this should be left to users to decide. 

Couldn't you release it as a separate helper package with extra handlers?

Side note: you can add any extra key to the configuration, and read it later. 
It doesn't need to be part of default_config.

I'll leave this issue opened because your handler may be used as example in the 
docs.

Original comment by rodrigo.moraes on 31 Jan 2012 at 4:26