Closed r9y9 closed 3 years ago
cc: @SeleDreams I've made some changes to your cmake config. Please check the items in the PR description.
I removed the hard-coded STATIC in add_libary
. If you want to build a static library, please set BUILD_SHARED_LIBS=OFF
like:
cmake -DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=OFF
cc: @SeleDreams I've made some changes to your cmake config. Please check the items in the PR description.
I removed the hard-coded STATIC in
add_libary
. If you want to build a static library, please setBUILD_SHARED_LIBS=OFF
like:cmake -DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=OFF
I see, no problem, I myself thought the static hardcoded was maybe not the best idea. I just originally wanted to make something simple to work with, adjusting the edited cmake of sinsy for it won't be hard (I modified sinsy on my local repo to use hts_engine as a submodule and include it directly from the cmake basically making the build process not rely of it being installed, which is better for windows
By the way, it was maybe better to keep the ${PROJECT_NAME} variable for add_library etc, since it allowed cmake to automatically account for changes in the project name if it ever changes
Thanks for the comment. I kept the use of ${PROJECT_NAME} in the CMakeLists.txt.
Finally, all green :) Merging.
Follow up for #14
Fixes #8
CMake changes from #14
Breaking
waf is no longer supported
TODOS