Closed taroushirani closed 4 years ago
Merging #108 into master will increase coverage by
17.16%
. The diff coverage is33.33%
.
@@ Coverage Diff @@
## master #108 +/- ##
===========================================
+ Coverage 64.45% 81.62% +17.16%
===========================================
Files 32 32
Lines 1899 1899
===========================================
+ Hits 1224 1550 +326
+ Misses 675 349 -326
Impacted Files | Coverage Δ | |
---|---|---|
nnmnkwii/io/hts.py | 93.58% <33.33%> (ø) |
|
nnmnkwii/autograd/_impl/modspec.py | 50.00% <0.00%> (+50.00%) |
:arrow_up: |
nnmnkwii/util/linalg.py | 100.00% <0.00%> (+62.50%) |
:arrow_up: |
nnmnkwii/paramgen/__init__.py | 75.00% <0.00%> (+75.00%) |
:arrow_up: |
nnmnkwii/autograd/_impl/mlpg.py | 96.00% <0.00%> (+96.00%) |
:arrow_up: |
nnmnkwii/baseline/gmm.py | 97.05% <0.00%> (+97.05%) |
:arrow_up: |
nnmnkwii/preprocessing/alignment.py | 97.53% <0.00%> (+97.53%) |
:arrow_up: |
nnmnkwii/paramgen/_mlpg.py | 100.00% <0.00%> (+100.00%) |
:arrow_up: |
nnmnkwii/autograd/__init__.py | 100.00% <0.00%> (+100.00%) |
:arrow_up: |
nnmnkwii/baseline/__init__.py | 100.00% <0.00%> (+100.00%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 616fc60...2628e3c. Read the comment docs.
Thanks for catching this. I also had a similar issue before but no idea why too. Anyway, LGTM.
Note to me: add a changelog entry
On environment which size of np.int is 4 bytes, HTSLabelFile.round_() may return negative start_time or end_time due to integer overflow. Replacing np.int with np.int64 solves this problem.
P.S. I have no idea why the size of np.int is 4 bytes even though anaconda's python is 64bit.