r9y9 / pyopenjtalk

Python wrapper for OpenJTalk
https://r9y9.github.io/pyopenjtalk/
Other
203 stars 69 forks source link

Introduce marine #40

Closed 6gsn closed 2 years ago

6gsn commented 2 years ago

This PR introduces marine, the module for estimating accent using the DNN-based method.

Motivation

The priory motivation of this PR is to enhance pyopenjtalk by introducing marine, which is the Japanese accent module using the DNN-based method.

What I did

Currently, extract_fullcontext() supports the creating the full-context label from texts. So, I added the option to activate the estimation using marine and the processing for estimating the Japanese accents using marine. And then, the accents will be applied to the full-context label.

To implement this modification, I also modified the existing feature as below;

Additional changes

Todo

6gsn commented 2 years ago

Hi, @r9y9! I believe this PR is ready for getting review. May I ask you to approve the workflow and review this PR?

6gsn commented 2 years ago

@r9y9 Sorry for the dumb error 😭 I fixed the error and checked that testing for lint passed in my local environment (also testing for pytest as well).

6gsn commented 2 years ago

Hi, @r9y9 I updated the docs and README as well 👍