search

r9y9 / pysinsy

Python wrapper for Sinsy
https://r9y9.github.io/pysinsy/
MIT License
51 stars 11 forks source link

Add extra compile flags #15

Closed crlotwhite closed 1 year ago

crlotwhite commented 1 year ago

Hello, I added a flag to fix the C++17 issue. https://github.com/r9y9/pysinsy/issues/13

I tested in Ubuntu WSL (latest) and Windows 11 environments.

r9y9 commented 1 year ago

Thank you for your PR! Using c++11 looks good to me, but there's a compile error on Mac OS X we need to fix. Looking at my local clang I find:

 gcc --help | grep std=
  -cl-std=<value>         OpenCL language standard to compile for.
  -std=<value>            Language standard to compile for
  -sycl-std=<value>       SYCL language standard to compile for.

So maybe worth trying -std=c++11 instead of --std=c++11 for OS X. If it doesn't work, we can leave compile options empty for OS X. Could you try to fix it?

crlotwhite commented 1 year ago

I tested the build on my m1 macbook. Oddly enough, the absence of the flag didn't cause any c++17 issues. So, I modified it not to add the flag even on macOS. (if it has some problem, I will specify the c++ version for macOS too.)

(I'm sorry about the lint issue, haha..;;)