search

r9y9 / pysptk

A python wrapper for Speech Signal Processing Toolkit (SPTK).
http://pysptk.readthedocs.io/en/latest/
Other
441 stars 79 forks source link

Add support to the RAPT pitch extraction algorithm #30

Closed jfsantos closed 8 years ago

jfsantos commented 9 years ago

I would like to use RAPT as the pitch extraction algorithm as in my (limited) experience it has slightly better performance than SWIPE'. Could you describe the required steps to add it? I can implement it myself and send a pull request.

r9y9 commented 9 years ago

I assume you have already found steps to support RAPT :).

Actually, I tried to expose the RAPT interface in SPTK one or two years ago, but I gave up to do that since the code was too complicated, I thought. Pull request is really welcome!

jfsantos commented 9 years ago

I still have not managed to wrap it. The code is really weird and dependant on using a linked list instead of an array as input. I might try to tackle this soon, but as I could not waste much time on this I implemented an ugly wrapper which simply pipes data in and out to the SPTK pitch binary.

r9y9 commented 9 years ago

Good news: I refactored the RAPT code a bit and probably was able to warp RAPT with a simple interface which takes input as an array instead of a linked list. I'm going to write a regression test to ensure my fixes don't do anything wrong.

jfsantos commented 9 years ago

This is great! Unfortunately I did not have time to help you review it, but I'm sure you did a great job. I will check this out this week to help test it.