r9young / DECO7140-Final-Project

0 stars 0 forks source link

Bug 4 - Larger Space between two parts #6

Closed r9young closed 4 months ago

r9young commented 4 months ago

image

r9young commented 4 months ago

Analysis

In the inspector, we can observe that the .flex-container-row class has a property of min-height: 60vh.

image

we also observe that there are two .flex-container-row in our css.


.flex-container-row {
    display: flex;
    flex-direction: row;
    /*min-height: 100vh;  /* Minimum height to cover the full viewport height */
    width: 100vw;       /* Width to cover the full viewport width */
}

.flex-container-row {
    display: flex;
    flex-direction: row;
    min-height: 60vh;  /* Minimum height to cover the full viewport height */
    /* width: 60vw; */
    /* width: 60vw;   bug-3*/
}

the effect on the website style is:

if the top css has the same property as the bottom one. It just cross it but include the new feature width:100vw;

image

r9young commented 4 months ago

Solution:

I delete the bottom one.

.flex-container-row {
    display: flex;
    flex-direction: row;
    min-height: 60vh;  /* Minimum height to cover the full viewport height */
    /* width: 60vw; */
    /* width: 60vw;   bug-3*/
}
r9young commented 4 months ago

Effect

image