search

rFlex / SCRecorder

iOS camera engine with Vine-like tap to record, animatable filters, slow motion, segments editing
Apache License 2.0
3.06k stars 583 forks source link

Applying Filter to Recorder produces unexpected Video output for Square video #103

Open Xcoder89 opened 9 years ago

Xcoder89 commented 9 years ago

I am trying to Apply realtime filter to SCRecorder. However I've noticed that the recorder renders a video output which is different to that which appears in recorder capture preview. The video output rect origin is around 40 px down the actual preview.

SCVideoConfiguration *video = _recorder.videoConfiguration; video.size = CGSizeMake(640, 640); video.scalingMode = AVVideoScalingModeResizeAspectFill; video.enabled = YES; video.filterGroup = [SCFilterGroup filterGroupWithFilter:[SCFilter filterWithName:@"CIColorMonochrome"]];

My previewView frame size is {320,320)

When I remove the line setting the filter everything works perfect.

Any help would be appreciated!!

Thanks

rFlex commented 9 years ago

I believe this issue has been fixed a while ago, can you confirm it?

Xcoder89 commented 9 years ago

@rFlex Thanks for the reply. I wont be able to confirm it now because I ended up removing all of that stuff. I see that you made a change in SCAssetExportSession but what I was talking about was applying Filters on the realtime camera preview. i.e recorder.CIImageRenderer = imageView; (imageView is an SCImageView)

mitchellporter commented 8 years ago

@Xcoder89 Did you ever figure this out? I'm experiencing the same issue. The video output rect is always a little bit off.