search

rFlex / SCRecorder

iOS camera engine with Vine-like tap to record, animatable filters, slow motion, segments editing
Apache License 2.0
3.06k stars 583 forks source link

snapshotOfLastVideoBuffer was not working #309

Open GabeRoze opened 8 years ago

GabeRoze commented 8 years ago

CIContext was nil, now its not.

mitchellporter commented 8 years ago

lol small world

GabeRoze commented 8 years ago

hah fancy meeting you here. Ever figure out what was wrong with your AVPlayer?

mitchellporter commented 8 years ago

Not yet, I took a break from it. Had some more people reach out to help, some promising leads. I may just move to paging.

rFlex commented 8 years ago

Hey, that's a great fix. Could you please refactor your change on mergeSegmentsUsingPreset so the code is not duplicated? You could make the original implementation figure out the outputUrl and call [self mergeSegmentsUsingPreset:preset atURL:outputUrl completion:completion]

rFlex commented 8 years ago

Also, it's a small detail but on the header you should add the specifiers to tell if an argument is optional or not. That way it integrates nicely with Swift :). Thank you so much!

AlexandrGraschenkov commented 7 years ago

Quick fix until pull request is open:

    let recorder = SCRecorder.shared()
    let context = SCContext(type: .auto)
    recorder.setValue(context.ciContext, forKeyPath: "_context")