search

rFlex / SCRecorder

iOS camera engine with Vine-like tap to record, animatable filters, slow motion, segments editing
Apache License 2.0
3.06k stars 583 forks source link

Fix auto exposure and autofocus not working properly. Issue 341 #355

Open raja-baz opened 7 years ago

raja-baz commented 7 years ago

The issue here is that when subject area change is detected, we try to do an autofocus on the centre of the image, then we wait for that focus operation to be done to put the camera back in continuous focus/exposure mode. The problem is that the front cam doesn't support that focus mode and the focus operation never completes. In fact, in _applyPointOfInterest:continuousMode:, focusing stays as NO. Now, if we cause the camera to get its exposure really high(by covering the lens for example) the image becomes all white, and no further subject area changes occur and we're now stuck in non-continuous mode.

The proposed fix is to disable this entire piece of logic if the camera is incapable of doing any kind of autofocus anyway. I've tested this change and it works well and I don't think it breaks anything. If it does, I'll be happy to fix it so it can be merged

freeubi commented 7 years ago

Tested, it really fixes the problem. Please merge it @rFlex :)