rHomelab / LabBot-Cogs

Cogs for the Red-based Homelab Discord server bot.

GNU General Public License v3.0

36 stars 14 forks source link

get ci pipelines functional, and switch to ruff linter/formatter #264

Open rippleFCL opened 7 months ago

rippleFCL commented 7 months ago

Initial Checklist

[x] Has @tigattack / @issy been added as a reviewer?
[x] If applicable, have the relevant project(s), milestone(s), and label(s) been applied?
[ ] If applicable, have you added details of the cog to the readme as per README.md?

Details

Does this resolve an issue? Resolves #

Changes

Features / Fixes

Adds feature/fix which does xyz.

Breaking Changes

Adds breaking change which causes \<issue>.

Additional

Any further notes or comments you want to make. im cool so i dont need to fill out the form

issy commented 7 months ago

Why autopep8 over black? Is there actually a tangible improvement here?

rippleFCL commented 7 months ago

main things id say are, black isnt compatible with pep8 or flake8. it also formats quotes to double quotes and it removes trailing commas. secondly (kinda unrelated) me and tig are thinking abt precommit formatting. currently the repo is more autopep8 compliant than it is black. also if we are using flake8 for linting, precommit formatting with black might cause issues there

issy commented 7 months ago

Yeah fair enough I guess. Sounds good

issy commented 7 months ago

While we're in the area, it might be a good time to version lock the CI dependencies. Reproducible builds are good

rippleFCL commented 6 months ago

so just for comment here i undid the decision on black vs autopep8 after bit more digging the linters can be made to play nice with black, i forgot how much easier black formated code is to read