search

rNeomy / auto-tab-discard

Use native tab discarding method to automatically reduce memory usage of inactive tabs
https://webextension.org/listing/tab-discard.html
Mozilla Public License 2.0
909 stars 79 forks source link

Whilelist keeps reseting to default #208

Closed Xalcer closed 3 years ago

Xalcer commented 3 years ago

Hi.

I just installed the extension on Chrome and works as expected, except the whitelist doesn't last long. After a few minutes, it goes blank again, ignoring whatever I've set.

rNeomy commented 3 years ago

So if you add a new URL to the list and press the save button and close the options page, on the next open, you don't see the URL?

Xalcer commented 3 years ago

If I open again inmediately it's still saved. It's after a few minutes or when I close and open the browser when it resets.

rNeomy commented 3 years ago

do you have any policy for this extension? chrome://policy/

Xalcer commented 3 years ago

No, it says it doesn't have any policies established.

rNeomy commented 3 years ago

I am not sure what could cause this. Can you try the extension on a clean profile?

inkhsutesou commented 3 years ago

image Same issue

Edit: Possibly nevermind. I keep trying to use this feature image Clicking on " Always " < " Keep tabs for this site " in the pop up menu

But then I have to go INTO the options page to hit save in order for it to persist between chrome sessions.

I believe it should save without having to go into options and pressing save.

Edit: Actually, now it's not changing the whitelist when I try to click " Always " < " Keep tabs for this site " for another site, it just keeps my old information.

rNeomy commented 3 years ago

The options page loads settings once it gets opened. So if you have it opened while you add a new hostname from the popup interface, you will need to refresh the page to see updates. Also, there is no need to save anything if you add hostnames from the popup interface.

Soraph commented 3 years ago

I have the same issue even after the latest update, it discard everything and disregard the settings like pinned tabs and whitelist, if I reboot the browser I have the whitelist empty

rNeomy commented 3 years ago

Let's debug:

  1. Open "chrome://extensions/" in a browser tab and turn the developer mode on
  2. Find the background page of this extension and switch to the Console tab
  3. Type "chrome.runtime.reload()" and see if you get an error on the background page.
Soraph commented 3 years ago

No errors

rNeomy commented 3 years ago

@Soraph can you reproduce this on the latest release? v0.4.6

Soraph commented 3 years ago

@rNeomy I can confirm that the issue is resolved with 0.4.6, I just checked with a browser restart and an OS restart (Brave on Win10). The options are persisted correctly and the tabs seems to behave as expected

rNeomy commented 3 years ago

perfect! @Xalcer can you confirm too?

Xalcer commented 3 years ago

It seems to work correctly now.

endymion0000 commented 3 years ago

There's still problems with the Exceptions whitelist in 0.4.6.

It still occasionally wipes the list and just now I had 2 domains in it from a previous session. I went to add about 4 or 5 new ones by visiting the sites one after the other and selecting Keep Tabs For This Site: Always. Reloaded the plugin options and the only one listed was the last one I did. The 2 were gone along with all of the new ones except that last one.

So while the list can persist, it may be the adding to the list process that sometimes is going awry.

rNeomy commented 3 years ago

@endymion0000 Should have been fixed by the new release. Thanks for the report.

endymion0000 commented 3 years ago

I'll await the release of 0.4.7 and see.