search

rNeomy / auto-tab-discard

Use native tab discarding method to automatically reduce memory usage of inactive tabs
https://webextension.org/listing/tab-discard.html
Mozilla Public License 2.0
929 stars 79 forks source link

Discarded tabs reload unintentionally #219

Open MaWu opened 3 years ago

MaWu commented 3 years ago

When I watch a video (for example on youtube) and switch to view a video in fullscreen mode the pinned tabs are reloaded. The activation of the tabs occurs on exiting the fullscreen mode of a video. This only happens with pinned tabs, normal (unpinned) and discarded tabs are not activated. This also only affects pinned tabs in the same window. When the video is viewed in a seperate window in fullscreen, the issue does not occur.

It might also have to do with another bug. I use the 'ignore hosts list' and the setting 'discard all pinned tabs when the browser is launched'. Despite of that, pinned websites that should not be discarded are discarded when the brower is launched. Maybe this is the same bug.

Steps to reproduce: Pin some tabs on firefox, open a new tab in the same window, go to youtube and watch a video, enter fullscreen then exit fullscreen mode on youtube. All discarded, pinned tabs reload unintentionally.

Browser : Firefox 87 (current version) 64bit OS: Windows 10

rNeomy commented 3 years ago

Despite of that, pinned websites that should not be discarded are discarded when the brower is launched.

Thanks for the report. It is fixed.

Steps to reproduce: Pin some tabs on firefox, open a new tab in the same window, go to youtube and watch a video, enter fullscreen then exit fullscreen mode on youtube. All discarded, pinned tabs reload unintentionally.

I am still not able to reproduce this. Seems like some preferences of the extension do conflict. Can you try on a clean profile to see if you can reproduce this? https://support.mozilla.org/en-US/kb/profile-manager-create-remove-switch-firefox-profiles

MaWu commented 3 years ago

Hi, Thank you for your support, the fast reply and for the fix.

I did some testing with the fullscreen issue. On a completely new and clean profile this issue persists. On the new profile the default settings of this addon were used, this produces the issue right away. However, I just installed the addon on my laptop (also Firefox Version 87), there are no problems at all when I exit fullscreen (also default settings). I will try to reproduce the issue on my laptop to see what triggers it.

Also, the settings page of the addon has the option "show protocols (for bug tracking)". Could this be useful for finding the issue? If so, where would I be able to read and provide the logs? In the console I found no entries related to the addon. Edit: nvm, found log under about:debugging, but no log entry is created when exiting fullscreen.

Best regards

rNeomy commented 3 years ago

Based on your comment, I think this is a FF bug. I don't think the extension is responsible for reloading the pinned tabs. Let's wait for the next FF release.

grahamperrin commented 3 years ago

@MaWu Firefox 88 was released a few days ago. Please, is this issue still reproducible?

MaWu commented 3 years ago

Hey @grahamperrin Unfortunately it is. My Firefox is updated to Version 88 and the issue still occurs every time. Did you try to fix this issue? If I can contribute something for you to get a clue why this happens, just let me know. Logfiles, debugger mode or debugger version of Firefox or whatever

grahamperrin commented 3 years ago

Thanks, I'm not a developer, but this issue caught my eye because it's vaguely comparable to a bug that's not yet reported by me …