search

rNeomy / auto-tab-discard

Use native tab discarding method to automatically reduce memory usage of inactive tabs
https://webextension.org/listing/tab-discard.html
Mozilla Public License 2.0
906 stars 79 forks source link

Bug: "close tab" with single-tab window malfunctions #264

Closed Luckz closed 2 years ago

Luckz commented 2 years ago

On Chrome at least (didn't test on FF), it's always™ been the case that the close tab function (as assigned to a hotkey f.ex.) can break horrendously if you have a single-tab window in front. It can instead close the active tab of another window, I suppose when switching to another window with more tabs while ATD is still looking for that first tab to close (?), and this is really hard to spot for the user – either they quickly ctrl-shift-T after it happens, or they lose a tab forever without even knowing about it.

The peculiar thing is that this can happen several minutes after pressing the hotkey.

rNeomy commented 2 years ago

I think I found the issue. Please reopen if you are still experiencing it after the 0.4.9 release.

Luckz commented 2 years ago

Now that you fixed that infinite loop problem, it seems safe to use. 👍🏻

Is it by the way WAD that the Close Tab hotkey (see above) won't close the last tab in a window?

rNeomy commented 2 years ago

Is it by the way WAD that the Close Tab hotkey (see above) won't close the last tab in a window?

No! Just a bug that is now fixed! Thanks for the report.