rNeomy / auto-tab-discard

Use native tab discarding method to automatically reduce memory usage of inactive tabs
https://webextension.org/listing/tab-discard.html
Mozilla Public License 2.0
888 stars 76 forks source link

[Ubuntu/Firefox Beta 106] Auto Discard Stopped Working #310

Open always-depends opened 1 year ago

always-depends commented 1 year ago

Auto (time-based) discard has stopped working. Tabs are not auto discarding when the time (5 min exceeding 1 inactive tab in my setup) is hit. It looks like this is related to the v0.6.3.2 release I received Sep 24, however Firefox v106 came out this week and it might be related to that as well. I don't have a firm grasp of when this broke. I'm only certain that it happened within the past few days. I'm running Firefox v106.0b3 64-bit on Ubuntu 22.04. Other than Firefox updating to 106 beta, my setup has remained fairly static.

always-depends commented 1 year ago

I performed a few experiments:

None of these fixed my issue. I know for a fact v0.5 was working fine. This appears to be an issue specific to Firefox v106 beta and Ubuntu v22.04.

Thereatra commented 1 year ago

I am having the same issue on Firefox Developer (same build v106.0b3 64-bit) on Windows 11. The only changes I'm aware of that was made to my system when the issue occurred was browser update.

always-depends commented 1 year ago

OK I actually have v0.5.0 working. For some reason I had to close the browser and reopen it after installing that version of the addon. @Thereatra perhaps this will help you in the meantime until the current version is fixed.

knoajp commented 1 year ago

After catching issue #307, the downgraded 0.5.0 worked fine. Then 0.6.3.2 was published, and it somehow worked, although its timer didn't work well sometimes. But now, its timer seems to be completely broken with Firefox 106.0b4. So I downgraded it again to 0.5.0, then it works fine currently.

Edit: Version 0.6.3.2 doesn't appear on about:performance list. If I turn the switch off/on on about:addons, it appears, but still doesn't work.

imcraymond commented 1 year ago

Also an issue with Windows 10. I've done a few things based on what was said in issue 307. Doing the following appears to make it work fine:

go to: about:debugging#/runtime/this-firefox select: "Inspect" for Auto Tab Discard copy/paste and run: chrome.runtime.reload()

Once i close the devtools windows it ceases functioning. I also saw the following in the devtools window after doing the reload: image

imcraymond commented 1 year ago

Also just got: image

rNeomy commented 1 year ago

Firefox has activated persistent=false on 106. I guess that's the reason the extension fails. Can you guys try the attached version and report back?

test.zip

always-depends commented 1 year ago

Thanks for looking into this! To help others in this thread, here's how you can test it.

  1. Save test.zip and rename it locally to test.xpi.
  2. Go to about:debugging in the awesomebar/urlbar/whatever it's called today and then click on "This Firefox" on the left-hand side.
  3. Click on the "Load Temporary Add-On" button in the top right and point it to the renamed XPI file in step 1.

At this point, you should be running the test add-on for this session. I haven't gotten there yet, but I believe everything is reverted once the browser closes.

@rNeomy It is working for me (Firefox v106.0b9, Ubuntu v22.04 64-bit)! Thank you so much!

knoajp commented 1 year ago

It works well for me, too. Thank you. Firefox 106.0 (beta) macOS 10.15.7

imcraymond commented 1 year ago

Sorry for the very late reply, I've been away for a bit. The test file worked fine for me too!

Any ideas when this may be pushed to Firefox addons?

Thanks.

always-depends commented 1 year ago

Also FYI Firefox v106 goes stable/public release today.

rNeomy commented 1 year ago

Also FYI Firefox v106 goes stable/public release today.

Version 0.6.4 is submitted to the store.