rNeomy / clean-uninstall

Remove addons fingerprints upon uninstall in Firefox browser
http://firefox.add0n.com/clean-uninstall.html
30 stars 6 forks source link

Version 0.2.0 stopped working in Pale Moon 27 #13

Open graciecat opened 7 years ago

graciecat commented 7 years ago

After upgrading from version 0.1.9 to 0.2.0, I noticed that Clean Uninstall stopped working. Clicking on the Open Cleaner button opens... nothing. Clean Uninstall does not try to delete any preferences when extensions are removed. Although it will install, it does not function.

This is in Pale Moon 27.4.2 (64-it) for Ubuntu 14.04.5 . Other Pale Moon users have noticed this, too.

I downgraded to version 0.1.9, and everything works.

graciecat commented 7 years ago

Follow-up: The issue appears to be, at least in part, the changes to background.js. Twenty-four "let" statements were changed to "const" statements. For example, lines 18-27 of background.js were changed from

//Polyfill
if (!Object.values) {
  Object.values = function (O) {
    let arr = [];
    for (let name in O) {
      arr.push(O[name]);
    }
    return arr;
  };
}

to

//Polyfill
if (!Object.values) {
  Object.values = function(O) {
    const arr = [];
    for (const name in O) {
      arr.push(O[name]);
    }
    return arr;
  };
}

So, a colleague changed the 24 instances of "const", back to "let" in background.js. With this reverse modification, Clean Uninstall 0.2.0 now appears to work in PM27.