rNeomy / reader-view

Access Firefox's built in reader view from right click context menu
https://webextension.org/listing/chrome-reader-view.html
Mozilla Public License 2.0
463 stars 73 forks source link

Extension crashes when switching to reader mode #156

Open IkelAtomig opened 1 year ago

IkelAtomig commented 1 year ago

As title say, it does. I need to reload the page and click again to switch to reader mode.

The crash happens. When the page is newly loaded and you try to switch to reader mode.

rNeomy commented 1 year ago

Is this on Chrome? What is the browser version?

IkelAtomig commented 1 year ago

This happens on Brave with latest version. Chromium 108 and Windows 11.

Head to https://techcrunch.com/2022/12/30/inside-matrix-the-protocol-that-might-finally-make-messaging-apps-interoperable/?guccounter=2

Load the page. Click the extension in toolbar. It won't switch to reader view. Either it crashes or you need to reload and to enter to reader mode.

https://www.theguardian.com/technology/2022/dec/08/twitter-sued-firing-female-workers-after-musk-buyout

Go to above page and hit the extension twice in Addressbar. You will see it as crashed.

rNeomy commented 1 year ago

It seems that this may be an issue with the worker. I was unable to replicate the issue. However, in the updated version of the extension, IndexedDB is being used to store temporary reader objects, which may resolve the issue. Please let me know once you have received the update.

IkelAtomig commented 1 year ago

image

This is what happens when I click the extension after the new update it doesn't change to reader mode. Literally broken.

IkelAtomig commented 1 year ago

Well, The extension seems to load pages smoothly at times. But at certain times. It crashes. Need to reload page and switch to the reader view.

Would be better to have smoother transitions.