pitkant
commented
3 years ago Seems good. Some notes:
- [x] Could you do a version bump on DESCRIPTION from 3.7.7 to 3.7.8?
- [x] test_xxx_restore_cache relies on naming (testxxx) to be run as the last test, maybe numbers could be used instead in this case? Although then all tests would need to be numbered like test1 (see https://stackoverflow.com/questions/32931886/is-it-possible-to-determine-test-order-in-testthat)
- [x] With testthat 3 it has become possible to run tests in parallel, maybe this setting should be then explicitly turned off in DESCRIPTION since test_xxx_restore_cache is dependent on being run last? (see https://testthat.r-lib.org/articles/parallel.html)
dieghernan
antagomir
Closes #223
See here an implementation of the new cache management. There is a suite of functions that detects the current cache dir (either set up via parameter, via
options(eurostat_cache_diror installed in the machine) and manages the download.A similar suite is implemented in two of my packages, already on CRAN: https://github.com/rOpenGov/giscoR and https://github.com/rOpenSpain/mapSpain
The current approach only writes on the temporary directory unless the user set a cache dir. Also, for storing the persistent cache dir with
rappdirsthe user needs to explicitly install the cache dir path withinstall = TRUE.I updated also some links, the cache parts on the functions that uses it and the
clean_eurostat_cachefunction.There is also a whole test suite for that. Note that the test suite also switches temporarly the cache dir to run the tests on a temporary dir, so no files are downloaded or removed on the local machine.
By last, I updated the GH check action to cache dependencies also for Windows (would reduce significantly the running time) and for showing the tests output.