rOpenGov / eurostat

R tools for Eurostat data
http://ropengov.github.io/eurostat
Other
234 stars 46 forks source link

eurostat 4.0.0 #283

Closed pitkant closed 8 months ago

pitkant commented 8 months ago

I suggest this version is uploaded to CRAN. I will run some final tests and post the results here before this is merged into master and submitted to CRAN

codecov[bot] commented 8 months ago

Codecov Report

Attention: 182 lines in your changes are missing coverage. Please review.

Comparison is base (dc987e7) 67.18% compared to head (31869b7) 76.41%.

Files Patch % Lines
R/get_eurostat.R 72.10% 53 Missing :warning:
R/set_eurostat_toc.R 35.82% 43 Missing :warning:
R/get_eurostat_json.R 64.19% 29 Missing :warning:
R/set_eurostat_cache.R 0.00% 16 Missing :warning:
R/label_eurostat.R 89.09% 12 Missing :warning:
R/cut_to_classes.R 28.57% 10 Missing :warning:
R/search_eurostat.R 50.00% 9 Missing :warning:
R/utils.R 62.50% 6 Missing :warning:
R/tidy_eurostat.R 96.96% 2 Missing :warning:
R/eurostat-defunct.R 0.00% 1 Missing :warning:
... and 1 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #283 +/- ## ========================================== + Coverage 67.18% 76.41% +9.22% ========================================== Files 24 23 -1 Lines 1024 1132 +108 ========================================== + Hits 688 865 +177 + Misses 336 267 -69 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pitkant commented 8 months ago

Checked on devtools::check_win_devel, devtools::check_win_release and devtools::check_win_oldrelease, all ok. Checked locally under

* using R version 4.3.2 (2023-10-31)
* using platform: aarch64-apple-darwin20 (64-bit)
* R was compiled by
    Apple clang version 14.0.0 (clang-1400.0.29.202)
    GNU Fortran (GCC) 12.2.0
* running under: macOS Sonoma 14.2

All ok except for 1 note:

Found the following (possibly) invalid URLs:
  URL: https://twitter.com/ropengov
    From: README.md
    Status: 403
    Message: Forbidden

This is due to Twitter API changes, the URL works ok

antagomir commented 8 months ago

Really cool