search

rOpenGov / fmi

Finnish Meteorological Institute open data API R client
Other
10 stars 7 forks source link

Fix undefined columns error and update README.md #25

Closed jlintusaari closed 6 years ago

jlintusaari commented 6 years ago

Fix the "undefined columns error" when using the function client$getDailyWeather. Also add Ubuntu installation instructions to readme.md.

antagomir commented 6 years ago

Thanksss !!

jlehtoma commented 6 years ago

Thanks a lot @lintusj1 . fmi is still very much in development and one thing which has changed - but was not yet reflected in README - is that since 0.2.0 a working installation of GDAL is not needed anymore. fmi imports rwfs which in turn imports sf which does depend on GDAL2. Since this is an upstream dependency, I've removed all installation instructions from fmi.

Nice work with tracing the changed field name!

jlintusaari commented 6 years ago

Thanks! I'm not sure if it would be better to still have those instructions. At least for me the package didn't work until I installed the GDAL packages. It may be quite difficult for a user to track what's failing in an upstream package.

jlehtoma commented 6 years ago

Which version of fmi and rwfs were you using? I think sf binary installation on Windows contains the necessary GDAL library. In addition, the latest versions of fmi and rwfs don't use GDAL CLI tools anymore (which required a functional GDAL installation).

jlintusaari commented 6 years ago

fmi version: 0.2.0 rwfs version: 0.1.16

I was using Ubuntu 16.04.

jlehtoma commented 6 years ago

Thanks again! rwfs >= 0.2.0 gets rid of the GDAL CLI tools so updating should remove the need for a separate GDAL installation. Would love to hear if this really is the case if you have time/interest to test.

jlintusaari commented 6 years ago

I wonder if it would be good to update the dependency version requirement also. I installed fmi from CRAN and it's description states that:

Imports: rwfs (>= 0.1.12), dplyr, magrittr, sp, tibble, tidyr, rgdal, raster

For some reason it didn't automatically install 0.2.0 and although possible, I don't think I had previously rwfs installed.

jlehtoma commented 6 years ago

AFAIK, fmi is not on CRAN - yet. It certainly is a good idea to update the import version requirement and this has been done in master of fmi (currently on 0.2.1).

jlintusaari commented 6 years ago

Ok very good, I probably remembered wrong and used install_github from devtools.