rOpenGov / fmi

Finnish Meteorological Institute open data API R client
Other
10 stars 7 forks source link

Re-write fmi #30

Open jlehtoma opened 6 years ago

jlehtoma commented 6 years ago

In its current form, fmi relies on rwfs for much of the functionality. It only implements one subclass and rest is setting up things. The generic architecture in rwfs is useful in principle, but it is painful to develop fmi... The class inheritance is unclear even for me and figuring what gets called and when is obscure. I've been struggling with this for years and I just don't thing the generic nature of rwfs justifies the complexity. Especially so since rgdal has improved a lot in terms of WFS access since rwfs was first created and sf is making things much easier. Much of the WFS-specific functionality that was in rwfs is just not needed anymore. Thus, I'm thinking about doing a re-write of the whole fmi package and retiring rwfs completely.

Any thoughts?