search

rOpenGov / fmi

Finnish Meteorological Institute open data API R client
Other
10 stars 7 forks source link

Submit to CRAN #5

Open antagomir opened 8 years ago

antagomir commented 8 years ago

Would be useful to take this to CRAN. I can do if there are no other volunteers. But I would still direct the emails to the main developer JJ. Any comments ?

statguy commented 8 years ago

Since I have moved on to very different kind of projects, I would be happy hand this package over to anyone who wants to continue the work. Note that if you want to put this to CRAN, you also need to put the rwfs package.

antagomir commented 8 years ago

I can't take over as this is not my core area and I maintain already >10 packages. But I can contribute by submitting to CRAN if we like to do that.

statguy commented 8 years ago

If doesn't require major involvement from me, then go ahead.

jlehtoma commented 8 years ago

I would indeed very useful to update the package and push it to CRAN. @torsti might be interested in getting involved in the package maintenance, I can help out as well. Apparently the current version is no longer working the FMI API, so the package needs more work than making sure it passes CRAN checks.

torsti commented 8 years ago

I'll try to take an initial look in the next week. I'd prefer to have a Python tool for my own FMI data needs. But if we get this working, maybe that would be enough.

jlehtoma commented 8 years ago

:+1: fantastic, let's have a look at this in case there's a quick fix (e.g. altered structures in the API).

BTW, for those interested in access through Python, there is also the FMI-weather-downloader GUI software for downloading the data over the FMI API. Not sure if it has an associated library, but in any case.

torsti commented 8 years ago

The downloader is a good tool for the things it does, but I've more need for a framework to work with than a few prepared alternatives. Though it uses the lxml python library, which if i remember correctly is based on libxml2, so there might be something in their approach that we could use if we end up building new functionality on top of the xml2 package from CRAN.

jlehtoma commented 8 years ago

As mentioned in issue #6, fmi (or actually rwfs) uses GDAL to read in the data, so no need (or hope) to parse it separately.

torsti commented 8 years ago

Ok, so rfws needs to go to CRAN first.

jlehtoma commented 8 years ago

Yep, I think so too. However, I think fixing fmi is a higher priority as it can always be installed from GitHub. But as for submitting it to CRAN, rwfs needs to go first.

ouzor commented 8 years ago

Having rwfs in CRAN would be nice for gisfin package too, since quite a lot of spatial data in Helsinki region is now made open via WFS APIs. I have some code for those that use rwfs in a separate branch of gisfin. So +1 for the plan!

On Sun, Jun 5, 2016 at 8:31 PM, Joona Lehtomäki notifications@github.com wrote:

Yep, I think so too.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rOpenGov/fmi/issues/5#issuecomment-223825948, or mute the thread https://github.com/notifications/unsubscribe/ABK-iv2GwD_qAzCujmQxgZNC5mLFISC0ks5qIwf0gaJpZM4Hw8Zs .