rOpenGov / geofi

R package for accessing Finnish geospatial data
https://ropengov.github.io/geofi/
Other
19 stars 6 forks source link

added code for adjusted plot in png output #34

Closed janikmiet closed 3 years ago

janikmiet commented 3 years ago

Modified tricolore vignette so that plot is adjusted in png output.

antagomir commented 3 years ago

Automated checks fail. Is it possible to fix these before merging by some changes to Git Actions in .github/workflows$ less R-CMD-check.yaml

janikmiet commented 3 years ago

Package 'useful' seems to be a problem. Last part of vignette uses that package. Where this package import should be added to?

antagomir commented 3 years ago

I think, by some changes to Git Actions in .github/workflows/R-CMD-check.yaml file (this path starts from the root directory of the repo).

janikmiet commented 3 years ago

Now it passes. I added packages to DESCRIPTION suggestions part.

antagomir commented 3 years ago

Aah yeah of course. I was thinking too much..

Thanks!!