rOpenGov / geofi

R package for accessing Finnish geospatial data

https://ropengov.github.io/geofi/

Other

19 stars 6 forks source link

municipality_key data seems to hold duplicates for year 2016 #35

Closed jhimberg closed 3 years ago

jhimberg commented 3 years ago

install.packages("geofi")

trying URL 'https://cran.rstudio.com/bin/macosx/contrib/4.0/geofi_1.0.0.tgz'

data("municipality_key") select(municipality_key, kunta, year, municipality_name_fi) %>% arrange(kunta, year)

A tibble: 2,828 x 3 kunta year municipality_name_fi

1 5 2013 Alajärvi 2 5 2014 Alajärvi 3 5 2015 Alajärvi **4 5 2016 Alajärvi 5 5 2016 Alajärvi** 6 5 2017 Alajärvi #install.packages("geofi") #trying URL 'https://cran.rstudio.com/bin/macosx/contrib/4.0/geofi_1.0.0.tgz'

muuankarski commented 3 years ago

Thank you for noting this! There were no changes needed for the code, rerunning the script generating the scripts was enough. Could have been a issue with Statistics Finland classification api or most probably a user error in executing the script in the first place. Fixed here https://github.com/rOpenGov/geofi/commit/09cf526fa35c780bd9bc80f6debe7c43be0d5818 and v1.01.1 on it's way to CRAN