search

rOpenGov / iotables

Importing and Manipulating Symmetric Input-Output Tables
https://iotables.dataobservatory.eu
Other
21 stars 8 forks source link

Minor release 0.4.4 #13

Closed antaldaniel closed 3 years ago

antaldaniel commented 3 years ago

I sent the current version with @KKulma and @pitkant added as contributors to CRAN, because for the preselection of the competition we need immediate news, and this will speed up communicating plans and expectations.

I'd like to blog about the existance of the package, and planned enhancements. I hope that these enhancements will be sent in a new, major release as 0.5 to CRAN in 2-3 weeks, with further blogposts on environmental impact analysis.

As all checks seem to work without a hiss, I sent in to CRAN 0.4.4

pitkant commented 3 years ago

Great! A new release in CRAN might be possible in 2-3 weeks but generally speaking publishing new package versions that often is advised against in CRAN Repository Policy:

"Submitting updates should be done responsibly and with respect for the volunteers’ time. Once a package is established (which may take several rounds), “no more than every 1–2 months” seems appropriate."

antaldaniel commented 3 years ago

Well, I don't think that this is a very mature package, and the current 0.4.4. is just very overdue maintainance with the dependencies and recently introduced CRAN policies.

The first submission did not pass, there are no \donttest{} rules, for example.

But if you think you can pick up the get_ghg issue and solve it, we can go for it now.

pitkant commented 3 years ago

I can help with sorting out CRAN checks if that helps, just post the check logs here. Adding \dontrun{} to tests that need an internet connection is a good idea anyway.

Implementing the new get_ghg() function falls too far away from my area of expertise for me to be comfortably able to evaluate whether it gives correct results or not.

antaldaniel commented 3 years ago

Here are the issues, they are very minor ones! https://win-builder.r-project.org/incoming_pretest/iotables_0.4.4_20210601_140326/Windows/00check.log

pitkant commented 3 years ago

I have now made the most obvious fixes and pushed them to master. The package checks were OK on my machine and on check_win_devel

KKulma commented 3 years ago

@antaldaniel @pitkant all checks are passing now on master, is it now good for the CRAN release?

antaldaniel commented 3 years ago

@KKulma My bad, that I did not close this, and you missed a few emails. It is on CRAN. We even tried to blog about it and get to Rbloggers.