Closed pitkant closed 3 years ago
This looks good, but there is a test that fails. Can you check:
FAILURE (test-pxweb_get.R:65:5): Previous bugs
? to see what the error is?
Seems to be this one - I am not sure what's the purpose of it.
test_that(desc="Previous bugs",{
# CRAN seem to run tests in parallel, hence API tests cannot be run on CRAN.
skip_on_cran()
# This is a bug in the previous implementation of pxweb
url <- "http://bank.stat.gl/api/v1/en/Greenland/BE/BE01"
tryr <- try(httr::GET(url), silent = TRUE)
if(!inherits(tryr, "try-error")){
expect_silent(px_meta_data <- pxweb_get(url))
expect_output(print(px_meta_data), regexp = "PXWEB LEVELS")
}
})
The test seems to have failed because pxweb url has changed from http to https form, which produced the following warning message, making the test fail since the test was obviously not silent:
url <- "http://bank.stat.gl/api/v1/en/Greenland/BE/BE01"
px_meta_data <- pxweb_get(url)
Warning message:
PXWEB URL CHANGE:
from: http://bank.stat.gl/api/v1/en/Greenland/BE/BE01
to: https://bank.stat.gl/api/v1/en/Greenland/BE/BE01
I can push a fix to this by replacing the old http url with a new https url, since it seems to me that the purpose of this test was not to replicate bugs... or was it? Could expect_warning would be more appropriate than expect_silent?
Ah, yes. Just fix that and I think we are all home.
I guess Appveyor checks can be disabled by removing Appveyor (and Travis CI) web hooks from Settings - Webhooks. They do not function as I removed the .yml files
Yes. Now fixed! Great work!
Change CI platform from Travis to GitHub Actions, as described in the linked issue
Close #211