search

rOpenGov / sweidnumbr

R package for Structural handling of identity numbers used in the swedish administration such as personal identity numbers (personnummer) and organizational identity numbers (organisationsnummer).
https://ropengov.github.io/sweidnumbr/
Other
8 stars 3 forks source link

new_period was removed from lubridate #114

Closed vspinu closed 4 years ago

vspinu commented 4 years ago

new_period/interval has been deprecated for several years now so we are finally removing it from lubridate.

This broke the revdep check.

Just replacing with the period/interval constructor should fix the problem.

Sorry for the trouble.

MansMeg commented 4 years ago

Cool. Now fixed. Will update at CRAN when all tests pass. I changed it but got this message:

Note: method with signature ‘Timespan#Timespan’ chosen for function ‘%/%’, target signature ‘Interval#Period’. "Interval#ANY", "ANY#Period" would also be valid

Although all tests are still fine?

vspinu commented 4 years ago

Thanks for a quick fix. I The ambiguous dispatch warnings should have been fixed in lubridate devel. I have just run sweidnumbr tests and check locally and all is good.

MansMeg commented 4 years ago

Now submitted to CRAN.