rOpenSpain / mapSpain

R package with the administrative boundaries of Spain, including CCAA, provinces and municipalities
https://ropenspain.github.io/mapSpain/
GNU General Public License v3.0
42 stars 3 forks source link

Typos on translation #36

Closed dieghernan closed 3 years ago

dieghernan commented 3 years ago

From the examples


vals <- c(
  "La Rioja", "Sevilla", "Madrid",
  "Jaen", "Orense", "Baleares"
)
esp_dict_translate(vals)
#> [1] "La Rioja"         "Seville"          "Madrid"           "Jaen"            
#> [5] "Ourense"          "Balearic Islands"
esp_dict_translate(vals, lang = "es")
#> [1] "La Rioja" "Sevilla"  "Madrid"   "Jaen"     "Orense"   "Baleares"
esp_dict_translate(vals, lang = "ca")
#> [1] "La Rioja"      "Sevilla"       "Madrid"        "Jaen"         
#> [5] "Ourense"       "Illes Balears"

In Spanish should be "Jaén", not "Jaen".

Review translator

dieghernan commented 3 years ago

Should be fixed now:

library(mapSpain)

vals <- c(
  "La Rioja", "Sevilla", "Madrid",
  "Jaen", "Orense", "Baleares"
)
esp_dict_translate(vals)
#> [1] "La Rioja"         "Seville"          "Madrid"           "Jaén"            
#> [5] "Ourense"          "Balearic Islands"
esp_dict_translate(vals, lang = "es")
#> [1] "La Rioja" "Sevilla"  "Madrid"   "Jaén"     "Orense"   "Baleares"
esp_dict_translate(vals, lang = "ca")
#> [1] "La Rioja"      "Sevilla"       "Madrid"        "Jaén"         
#> [5] "Ourense"       "Illes Balears"

sessionInfo()
#> R version 4.0.3 (2020-10-10)
#> Platform: x86_64-w64-mingw32/x64 (64-bit)
#> Running under: Windows 10 x64 (build 19042)
#> 
#> Matrix products: default
#> 
#> locale:
#> [1] LC_COLLATE=Spanish_Spain.1252  LC_CTYPE=Spanish_Spain.1252   
#> [3] LC_MONETARY=Spanish_Spain.1252 LC_NUMERIC=C                  
#> [5] LC_TIME=Spanish_Spain.1252    
#> 
#> attached base packages:
#> [1] stats     graphics  grDevices utils     datasets  methods   base     
#> 
#> other attached packages:
#> [1] mapSpain_0.2.2.9000
#> 
#> loaded via a namespace (and not attached):
#>  [1] Rcpp_1.0.5         knitr_1.30         magrittr_2.0.1     units_0.6-7       
#>  [5] tidyselect_1.1.0   R6_2.5.0           rlang_0.4.10       stringr_1.4.0     
#>  [9] highr_0.8          dplyr_1.0.2        tools_4.0.3        grid_4.0.3        
#> [13] xfun_0.19          KernSmooth_2.23-17 e1071_1.7-4        DBI_1.1.0         
#> [17] ellipsis_0.3.1     htmltools_0.5.0    class_7.3-17       yaml_2.2.1        
#> [21] digest_0.6.27      countrycode_1.2.0  tibble_3.0.4       lifecycle_1.0.0   
#> [25] crayon_1.3.4       sf_0.9-8           purrr_0.3.4        vctrs_0.3.6       
#> [29] glue_1.4.2         evaluate_0.14      rmarkdown_2.6      stringi_1.5.3     
#> [33] pillar_1.4.7       compiler_4.0.3     generics_0.1.0     classInt_0.4-3    
#> [37] pkgconfig_2.0.3

Created on 2021-04-18 by the reprex package (v0.3.0)