search

rSimulate / Cosmosium

:earth_americas: js game engine for space-based games
Other
23 stars 7 forks source link

[Question/Discussion] Importing bottle as a static lib? #65

Closed BrianErikson closed 10 years ago

BrianErikson commented 10 years ago

Python shouldn't (and doesn't) have any issues dynamically importing bottle from the PATH; at least on my desktop. I've went ahead and fixed all the bottle imports from "py.lib.bottle" to just "bottle" on my fork. Is there any reason we're doing this when bottle should be in python's PATH instead?

BrianErikson commented 10 years ago

It just dawned on me that you guys might be intending on modifying bottle.py...? If that's the case, git still isn't importing submodules in INSTALL.py. Have you guys looked into GitPython?

All we'd have to worry about is the user making sure PIP is installed (and python of course), and then have pip install all of the dependencies, including GitPython, and then GitPython can install all the required submodules. I'm working on a test install script now that might work.

EDIT: Install script is done. Let me know what you think!

7yl4r commented 10 years ago

The install script I wrote doesn't put bottle into python's path, but clones the bottle repo into the py/lib/ directory. The only reason I did this really was because I wanted to play with git submodules. =)

These changes look good I think. Can you submit a pull request from BranErikson/Cosmosium to rSimulate/Cosmosium, so we can test them out?

BrianErikson commented 10 years ago

Request submitted!

BrianErikson commented 10 years ago

Issue was resolved through the install script importing submodules correctly