search

ra1028 / DifferenceKit

💻 A fast and flexible O(n) difference algorithm framework for Swift collection.
https://ra1028.github.io/DifferenceKit
Apache License 2.0
3.56k stars 241 forks source link

Support macOS with Apple Silicon #118

Open Shakarang opened 4 years ago

Shakarang commented 4 years ago

Apple will release a new type of Mac having a different architecture than x86_64. This architecture is called Apple Silicon (arm64) and requires projects with custom VALID_ARCHS to add it in their VALID_ARCHS.

Checklist

Expected Behavior

DifferenceKit can be used on macOS having the Apple Silicon architecture.

Current Behavior

The Apple Silicon architecture (arm64) is not in the valid architectures of the project.

Steps to Reproduce

Build the framework and use the lipo -info command to see that the architecture is missing.

taoshotaro commented 3 years ago

Since VALID_ARCHS is not used by default in Xcode 12, isn't it better to remove VALID_ARCHS from the xcconfig?

ra1028 commented 3 years ago

Fixed https://github.com/ra1028/DifferenceKit/pull/124